fix(plugins): resolve DSH_HOME to an absolute root like the core - #2644

Verdict: PASS at 0fc8eed
Written-by: Reviewer
Attestation: 0fc8eed role=Reviewer

Review — #2644 fix(plugins): resolve DSH_HOME to an absolute root like the core

Tip 0fc8eedce614124f0f16ff380a5a24ef241f4010 (base dafedecec44f), 13 files +311/−3. Read through the contents API at the tip; the core rule was read at the base sha.

Tier / CI. risk-tier: T3; basis: plugins/social/index.js=T3, plugins/social/src/dsh-home.js=T3, … (risk-gate's judge() over the base risk-rules.json). All 18 check-runs at the tip are terminal, none in progress: tests-ok success, Node 24 · DSH 0.2.0-rc.2 success, merge-gate success, plugins (tree|social|timeline|workflow) success, package success. enqueue-guard is red only with do not enqueue #2644: no Verifier report names the tip 0fc8eedce614 — the expected "no PASS yet" refusal at this tip, and not the lists no command it ran case, so this PASS replaces nothing.

1. The rule is the core's, not a lookalike. plugins/*/src/dsh-home.js:8 is export const dshHomeOf = (value = process.env.DSH_HOME) => resolve(expandHome(value?.trim() ? value : join(homedir(), '.dsh'))). core/src/host/folders.js:18 at the base is the same expression without the env default, and line 14's expandHome is character-identical (~ → homedir(), /^~[\\/]/ → join(homedir(), text.slice(2)), else the text). So '' and ' ' both land on homedir()/.dsh (value?.trim() is falsy), ~ and ~/x expand, and the answer is resolve()d. It uses os.homedir(), as the core does, not process.env.HOME — where the two disagree the core's answer wins by construction — and an unset HOME now falls back to the account entry instead of the old literal ..

2. Wiring uses only the helper; default names and overrides are untouched. social index.js:30-31: const dshHome = dshHomeOf() then credentialsPath: join(dshHome, 'bot', 'flybot-social.json'), ...config — the spread comes after, so an explicit credentialsPath still wins. timeline index.js:99-100: const { dir = join(dshHome, 'bot', 'flybot-timeline'), … } = config — config.dir still wins. workflow index.js:31,98: dir: persist ? (config.dir ?? join(dshHome, 'bot', 'flybot-workflow')) : undefined — config.dir still wins. No process.env.DSH_HOME remains in any of the three entry points, and all three default subdirectory strings are byte-identical to the old ones.

3. Red first, measured. In a scratch copy built from the tip files, with the three index.js lines put back to process.env.DSH_HOME ?? join(process.env.HOME ?? '.', '.dsh'): social 2 tests / 1 pass / 1 fail — the saved server is read from the DSH home, expected ['https://peer.test'], actual []; timeline 2 / 0 / 2 — the trace root is absolute… expected true actual false, and expected /tmp/flybot-timeline-home-*/.dsh/bot/flybot-timeline actual ' /bot/flybot-timeline'; workflow 2 / 0 / 2 — the workflow store lands in the DSH home… and the blank-value test, expected true actual false (the store lands beside the cwd). social's second test still passes on the reverted entry because it exercises the helper directly — that is the one test of the six that is expected to stay green, and it does.

4. The three helpers are one file. Same blob 057c3cfe0d56c8218b685e72400feae1f3d8f91d and same sha256 bc02a86b0e5a70be8d6f18269f4cae74b7924028421af5128d2bddf8a4b1f467 (596 bytes each). Imports are node:os and node:path only — no core/ path, so patch generation and CI cannot be broken by a cross-package import.

5. Scope. Exactly the 13 declared files: changelog.d/2643.fixed.md, docs/subsystems/{social,timeline,workflow}.md, and the three index.js + src/dsh-home.js + test/dsh-home.test.js triples. A grep for DSH_HOME under plugins/ at the base lists only those three entries as resolve sites, so no other call site was missed and nothing outside the issue was edited.

6. Checkpoint. parseCheckpoint + checkpointReasons(body, { pr: 2644, files }) from enqueue-rules.mjs returns []: pr 2644; claim Dev matching Owner: Dev; issue 2643 matching Fixes #2643; summary 566 characters in 4 sentences; 12 files, all in the diff; checks.at the full tip; the block is 1363 characters (limit 1500).

7. Base is behind, the tree is not dirty. The branch sits on dafedecec44f while main is 93df47fd (#2642). The only overlap between #2642 and this change set is docs/subsystems/social.md, and GitHub reports mergeable: true (mergeable_state: unstable only because enqueue-guard is red), so there is no conflict to resolve here. If a queue rebuild goes red, it is main's plugins/social/src/face-rooms.js / social-doc change landing beside this diff rather than this change set, and the repair is a rebase, not a rewrite of this branch.

Ran:

$ sha256sum plugins/{social,timeline,workflow}/src/dsh-home.js
bc02a86b… ×3
$ cd /tmp/r2644/plugins/social && TZ=UTC DSH_HARNESS=/data/dsh/bot/workspace/d2607/repo/core/dev/harness node --import ./test/resolve.mjs --test test/dsh-home.test.js
# tests 2 / pass 2 / fail 0
$ cd /tmp/r2644/plugins/timeline && TZ=UTC DSH_HARNESS=/data/dsh/bot/workspace/d2607/repo/core/dev/harness node --import ./test/resolve.mjs --test test/dsh-home.test.js
# tests 2 / pass 2 / fail 0
$ cd /tmp/r2644/plugins/workflow && TZ=UTC DSH_HARNESS=/data/dsh/bot/workspace/d2607/repo/core/dev/harness node --import ./test/resolve.mjs --test test/dsh-home.test.js
# tests 2 / pass 2 / fail 0
$ sed -i 's|const dshHome = dshHomeOf()|const dshHome = process.env.DSH_HOME ?? join(process.env.HOME ?? ".", ".dsh")|' plugins/{social,timeline,workflow}/index.js && node --test test/dsh-home.test.js (same three directories)
# social 1 fail 1 pass; timeline 0 pass 2 fail; workflow 0 pass 2 fail

Not run: npm run verify at the tip and the smoke test on this machine (there is no checkout of the tip here); CI's tests-ok covered test, plugins (tree|social|timeline|workflow) and package at this tip instead, and the new tests drive the real plugin apply() entry point.